Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(command): adding args to use line #1210

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(command): adding args to use line #1210

wants to merge 2 commits into from

Conversation

danmx
Copy link

@danmx danmx commented Aug 27, 2020

Adding args to use line

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

This PR is being marked as stale due to a long period of inactivity

@danmx
Copy link
Author

danmx commented Oct 27, 2020

@jpmcb could you take a look?

@umarcor
Copy link
Contributor

umarcor commented Oct 27, 2020

Ref #842

@jpmcb
Copy link
Collaborator

jpmcb commented Dec 29, 2020

Hi @danmx thanks for this PR - would you be able to add a test for this? Maybe in command_test.go? A passing test will help this get reviewed and merged in

@github-actions github-actions bot added the size/S Denotes a PR that chanes 10-24 lines label Aug 18, 2022
@danmx danmx force-pushed the useline_args branch 2 times, most recently from fc97c0c to e481b1f Compare September 24, 2023 16:07
@danmx
Copy link
Author

danmx commented Sep 24, 2023

@jpmcb took me some time but I've added tests for UseLine.

@danmx danmx force-pushed the useline_args branch 5 times, most recently from 0179759 to 64cff20 Compare September 24, 2023 16:29
@github-actions
Copy link

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@danmx
Copy link
Author

danmx commented Oct 1, 2023

@marckhouzam I see that you were active recently. Could you take a look at this PR?

I addressed the previous comment about adding tests.
I had to reshuffle Command struct optimal memory usage (fixing violations of maligned linter) because I added another bool field.

@github-actions
Copy link

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@Reikimann Reikimann mentioned this pull request Jul 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/S Denotes a PR that chanes 10-24 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danmx @CLAassistant @umarcor @jpmcb