Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion support for Nushell #1857
base: main
Are you sure you want to change the base?
Completion support for Nushell #1857
Changes from all commits
9f4bdb8
e687d2e
0e4db1b
1c908e1
95f2d8e
4ad4930
f366bb2
fe8bf5e
b3a1d72
cfee99c
6e3abc6
49d5881
107986c
cb60acd
303dd25
3c8715a
aaf5cf8
99c3692
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well check for
ShellCompDirectiveFilterDirs
here also, since it is also not supported.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is valid for a program to request file completion for a flag value. For example:
This currently works.
However, if we use the
=
for it does not:I'm not sure if you will be to handle that case or not. If not, we'll just have to live with it. It's not critical.