Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PersistentPreRun to disable required flag for help and completion command #1992

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

add PersistentPreRun to disable required flag for help and completion command #1992

wants to merge 14 commits into from

Commits on Jul 9, 2023

  1. DisableFlagParsing in helpCommand set to true

    @JunNishimura
    JunNishimura committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    85e8097 View commit details
    Browse the repository at this point in the history

  2. DisableFlagParsing in bash, zsh, fish, powershell set to true

    @JunNishimura
    JunNishimura committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    43e4ad4 View commit details
    Browse the repository at this point in the history

  3. add TestHelpCommandExecutedWithPersistentRequiredFlags

    @JunNishimura
    JunNishimura committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    314c9b8 View commit details
    Browse the repository at this point in the history

  4. add test to check required flags will be ignored for bash, zsh, fish,… 

    … powershell completion
    @JunNishimura
    JunNishimura committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    10b0388 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. add PersistentPreRun for help command 

    Disable any persistent required flags for the help command
    @JunNishimura
    JunNishimura committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    4b81cd5 View commit details
    Browse the repository at this point in the history

  2. add PersistentPreRun for completion command 

    disable any persistent required flags for the completion command
    @JunNishimura
    JunNishimura committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    94a3cb1 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. call Root PersitentPreRun on HelpCommand

    @JunNishimura
    JunNishimura committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    2d1eeaf View commit details
    Browse the repository at this point in the history

  2. call Root PersistentPreRun on Completion Command

    @JunNishimura
    JunNishimura committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    ef1328f View commit details
    Browse the repository at this point in the history

  3. add TestPersistentPreRunHooksForHelpCommand

    @JunNishimura
    JunNishimura committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    ba4e21d View commit details
    Browse the repository at this point in the history

  4. add TestPersistentPreRunHooksForCompletionCommand

    @JunNishimura
    JunNishimura committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3bb59c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. fix help command: use PersistentPreRunE instead of PersistentPreRun

    @JunNishimura
    JunNishimura committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b370e7b View commit details
    Browse the repository at this point in the history

  2. fix completion command: use PersistentPreRunE instead of PersistentPr… 

    …eRun
    @JunNishimura
    JunNishimura committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    46a2ba8 View commit details
    Browse the repository at this point in the history

  3. define trueString constant

    @JunNishimura
    JunNishimura committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    f3125ff View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Merge branch 'main' into disableMarkPersistentRequiredFlagForHelpAndComp

    @JunNishimura
    JunNishimura committed May 25, 2024
    Configuration menu
    Copy the full SHA
    e86f386 View commit details
    Browse the repository at this point in the history