fix documentation of Command.SetOut method

[kanaksinghal]

This change fixes a misleading documentation issue for methods: SetOut, SetErr, SetIn & SetOutput

In Command.SetOut, the statement "If newOut is nil, os.Stdout is used" was misleading as Command.Print prints to os.Stderr when outWriter = nil

The defaults are based on the getter being used i.e. one of OutOrStdout or OutOrStderr. i.e. there is no default.

[CLAassistant]

All committers have signed the CLA.

[marckhouzam]

I agree that there is an inconsistency here. I also feel the use of OutOrStderr by Print() is a bug we are stuck with due to backwards-compatibility.

Now, if you don't call SetOut() or call it with nil, the existing printouts of cobra will default to stdout, so the comment feels right to me. If you add printout using Pint() then you justifiably get confused, but there isn't much we can do about it.

So I don't think changing the comment will clarify things. That is why the comment for Print() mention stderr.

[kanaksinghal]

I see, thanks for clarifying 🙂 👍