Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fully inactivated linters #2148

Merged
merged 2 commits into from
May 19, 2024
Merged

Remove fully inactivated linters #2148

merged 2 commits into from
May 19, 2024

Commits on May 18, 2024

  1. Remove fully inactivated linters 

    Currently golangci-lint fails with these errors:

ERRO [linters_context] golint: This linter is fully inactivated: it will not produce any reports.
ERRO [linters_context] interfacer: This linter is fully inactivated: it will not produce any reports.
ERRO [linters_context] maligned: This linter is fully inactivated: it will not produce any reports.

I could not find any docs explaining what "fully inactivated" mean, but
based this PR[1] it seems that these linters do nothing now. Removing
the linters fixes this issue without changing linting, as they did not
produce any report.

Looking in the linters docs[2] I did not find a replacement for
"interfacer" and "malinged" linters. "stylecheck" seems to be a
replacement for "golint", but we need to fix the code to enable it.

[1] golangci/golangci-lint#4436
[2] https://golangci-lint.run/usage/linters/
    @nirs
    nirs committed May 18, 2024
    Configuration menu
    Copy the full SHA
    0585a83 View commit details
    Browse the repository at this point in the history

  2. Add stylecheck linter, replacement for golint 

    This revealed 2 capitalized error messages.

https://golangci-lint.run/usage/linters/#stylecheck
    @nirs
    nirs committed May 18, 2024
    Configuration menu
    Copy the full SHA
    f43fbd5 View commit details
    Browse the repository at this point in the history