Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #71

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Add support for Python 3.12 #71

merged 2 commits into from
Mar 13, 2024

Conversation

Rogdham
Copy link
Contributor

@Rogdham Rogdham commented Mar 13, 2024

Fixes #70

Open questions to owner of the repo:

  • GitHub action: make versino 3.10 to 3.12 mandatory for PR to be build? (currently only 3.7 to 3.9 are required)
  • Do you want to drop support for 3.7 as it is not supported anymore?

@Rogdham Rogdham marked this pull request as draft March 13, 2024 18:27
@langston-barrett
Copy link
Collaborator

I'm seeing a CI failure:

Traceback (most recent call last):
  File "/home/runner/work/autoprogram/autoprogram/setup.py", line 6, in <module>
    from setuptools import setup, find_packages
ModuleNotFoundError: No module named 'setuptools'
Error: Process completed with exit code 1.

GitHub action: make versino 3.10 to 3.12 mandatory for PR to be build? (currently only 3.7 to 3.9 are required)

Yep, I'll change this.

Do you want to drop support for 3.7 as it is not supported anymore?

Sure!

@Rogdham
Copy link
Contributor Author

Rogdham commented Mar 13, 2024

I have just added setuptools in the GitHub action script (not installed by default on Python 3.12).

Note that many packages are now switching to build PEP 517, but this is probably out of the scope of this PR.

@langston-barrett
Copy link
Collaborator

Note that many packages are now switching to build PEP 517, but this is probably out of the scope of this PR.

Feel free to file an issue for this!

@Rogdham Rogdham marked this pull request as ready for review March 13, 2024 18:42
@Rogdham
Copy link
Contributor Author

Rogdham commented Mar 13, 2024

Alright, I have created #72, but will probably leave the implementation to someone else.

As far as this PR is concerned, I think it is ready to be reviewed!

Copy link
Collaborator

@langston-barrett langston-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@langston-barrett langston-barrett merged commit c6b21b1 into sphinx-contrib:master Mar 13, 2024
5 checks passed
@Rogdham Rogdham deleted the py312 branch March 13, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test against Python 3.12
2 participants