Skip to content

Commit

Permalink
Merge pull request #1028 from sphinx-contrib/support-inlined-images-i…
Browse files Browse the repository at this point in the history
…n-v2-editor

translator: support inlined images in v2 editor
  • Loading branch information
jdknight authored Aug 9, 2024
2 parents f1bb347 + 14a8b91 commit 2bbf123
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions sphinxcontrib/confluencebuilder/storage/translator.py
Original file line number Diff line number Diff line change
Expand Up @@ -1853,6 +1853,8 @@ def _visit_image(self, node, opts):
attribs['ac:align'] = alignment
if alignment == 'right':
attribs['ac:style'] = 'float: right;'
elif self.v2:
attribs['ac:inline'] = 'true'

if 'alt' in node:
alt = node['alt']
Expand Down
1 change: 0 additions & 1 deletion tests/validation-sets/restructuredtext/images.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Images

Limitations using the Fabric (``v2``) editor:

- Images cannot be inlined (`CONFCLOUD-68501`_).
- SVGs may not render properly (`CONFCLOUD-1762`_).

reStructuredText defines a series of `image-based directives`_. Example markup
Expand Down

0 comments on commit 2bbf123

Please sign in to comment.