Issue 1059: Fix downloadable abs path #1060
Conversation
Paldari
force-pushed
the
bugfix/download-absolute-path
branch
from
5b8bdc3
to
afe1ab6
Compare
|
Ha... the test I added is obviously failing on windows since the path separator I used in the test is the Unix one... I think even on Windows a lot of people would actually use the Unix separator, so I should update the PR. |
Paldari
force-pushed
the
bugfix/download-absolute-path
branch
3 times, most recently
from
134f815
to
73e28ff
Compare
Signed-off-by: Kevin DARNE <[email protected]>
Paldari
force-pushed
the
bugfix/download-absolute-path
branch
from
73e28ff
to
de10ee0
Compare
|
PR should be fine for review now. Issue was just that a path starting with Cheers |
A series of download entries have been added to help verify project-relative paths are resolved. Extended the Confluence-related checks to verify that expected view-file macros are generated. Signed-off-by: James Knight <[email protected]>
|
Thanks for taking the time to address the issue and present a clean/signed change request, as well as reporting the issue. Sorry for the regression on this. Hopefully future changes won't break this again. Merged; and it should be available next release. |
fixes #1059
This is quick fix for the regression discussed in issue 1059.