Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_build_html: test_html_scaled_image_link: allow newlines between HTML img and anchors #11863

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Purpose

  • Updates a unit test to accomodate modified output of docutils 0.21b (unreleased).

Detail

  • In the test case, allow newlines between HTML img and a (anchor) elements when searching for a match.

Relates

@jayaddison
Copy link
Contributor Author

On self-review: would it be worth adding docutils-version-awareness to this change, the same way that #11818 did?

@jayaddison
Copy link
Contributor Author

On self-review: would it be worth adding docutils-version-awareness to this change, the same way that #11818 did?

For consistency: yes, I think it does make same to apply the same conditional check here. No further changes planned.

@AA-Turner AA-Turner merged commit 3b5d2af into sphinx-doc:master Jan 10, 2024
22 checks passed
@AA-Turner
Copy link
Member

Thanks!

A

@jayaddison jayaddison deleted the issue-11862/test-build-html-docutils-newline-fixup branch January 10, 2024 10:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_build_html: test_html_scaled_image_link: change in docutils HTML output causes test failure
2 participants