run coverage check on PRs #11880
Closed
run coverage check on PRs #11880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AA-Turner i find it strange that coverage is not configured to run on PRs since that prevents codecov from reporting the coverage diff. Is there a reason its set up this way? Also strange that the tests are passing but the coverage job is not passing in this PR... any ideas? |
|
We disabled this on PRs due to time and that coverage information isn't used by anyone currently. |
Well of course it isn't used by anyone, it isn't generated! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run coverage checks on PRs so codecov can comment on the coverage change