-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typecheck docs/conf.py #12697
typecheck docs/conf.py #12697
Conversation
cf17714
to
a7f25e3
Compare
@@ -177,7 +177,7 @@ def merge_members_option(options: dict) -> None: | |||
|
|||
# Some useful event listener factories for autodoc-process-docstring. | |||
|
|||
def cut_lines(pre: int, post: int = 0, what: str | None = None) -> Callable: | |||
def cut_lines(pre: int, post: int = 0, what: str | list[str] | None = None) -> Callable: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also update the signature of between
below since they are hooks for the same event (but you can also do it in a follow-up PR since it's not directly tight to docs/conf.py
itself).
a7f25e3
to
3a24dcb
Compare
Good for me! you can do the follow-up PR on |
@picnixz I think the merge may have been slightly premature here -- the force push removed several changes, such as ensuring imports were in type checking block. More minor, but also can we ensure that commit messages start with an imperative (eg Check doc/conf.py with mypy or etc). A |
Ah, actually, you marked the conversation as being resolved, so I assumed you wanted to keep it out (is it what you were thinking about)? We can revert the commit if needed though and amend the PR.
Ah yes, this is something I wondered. I used for a long time |
No description provided.