Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx13 theme: Include the project name in home link #12700

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

timhoffm
Copy link
Contributor

So far, only the sphinx logo was contained in the home link. This PR includes also the project name "Sphinx" in the link.

So far, only the sphinx logo was contained in the home link.
This PR includes also the project name "Sphinx" in the link.
@picnixz
Copy link
Member

picnixz commented Jul 28, 2024

I assume that it actually doesn't change the rendering and that the h1 was a fake h1 right? (like, the size of the span is eventually the same)

@timhoffm
Copy link
Contributor Author

timhoffm commented Jul 28, 2024

Correct. See the built docs.

@picnixz picnixz merged commit feeee57 into sphinx-doc:master Jul 28, 2024
7 checks passed
@timhoffm timhoffm deleted the sphinx13-logo-clickable branch July 28, 2024 10:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
@AA-Turner AA-Turner added this to the 8.0.0 milestone Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants