Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Builder a subclass of abc.ABC #12997

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AA-Turner
Copy link
Member

Closes #12996

cc @chrisjsewell, having written the PR I'm not sure it's worth it. What do you think?

A

@chrisjsewell
Copy link
Member

I think it makes sense; harder to mess up writing a builder 🤷 (also I made #12998)

@AA-Turner
Copy link
Member Author

The slight challenge is that if you use write_documents() then write_doc and get_target_uri aren't required if you don't use them, which could be annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Builder inherit from abc.ABC
2 participants