LaTeX: fix #13007 #13009
Merged
LaTeX: fix #13007 #13009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change at 8.1.0 related to the rendering in PDF of admonitions broke the build if user LaTeX installation was lacking both of fontawesome5.sty and fontawesome.sty. This was due to a missing change to some auxiliary LateX in sphinx.sty related to rendering of title bar icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change at 8.1.0 related to the rendering in PDF of admonitions breaks the build if user LaTeX installation is lacking both of fontawesome5.sty and fontawesome.sty. This is due to a missing update of 7.4.0 auxiliary LaTeX in sphinx.sty related to rendering of title bar icons.
Fix #13007.
Sorry about this oversight. The 7.4.0 was tested with LaTeX environments lacking fontawesome5.sty and fontawesome.sty but the change which got merged into 8.1.0 forgot to do again those tests which would have revealed the issue.
To add a unit test for this is not easy because Sphinx has to be tricked to believe it is lacking a LaTeX dependency which does exist in our CI, so I will return at a later date to incorporate such a test into our CI PDF builds.
To recap: the issue arises only if user LaTeX installation is lacking both of fontawesome5.sty and fontawesome.sty. But note that our documentation says:
@AA-Turner Despite the fact that #13007 would not have arisen if the above dependencies had been installed, I opened a 8.1.x milestone, but perhaps we can downgrade the severity of the bug and have this PR merged later. (I had forgotten we did say explictly that on Ubuntu
texlive-fonts-extrais required, so the severity of the bug is less than I thought initially).