Remove custom command line interface #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package shipped with its own CLI `aiida-s3`. The only function was to provide a command that allowed creating new AiiDA profiles using any of the storage backends. As of `aiida-core==2.5`, the command `verdi profile setup` was added to `verdi` that dynamically creates a subcommand for each storage plugin that is registered. The requirement is updated to `aiida-core~=2.5`. The custom CLI is removed entirely. The storage plugins remove the `_get_cli_options` methods and adds the new pydantic model definition that replaces it.
sphuber
force-pushed
the
feature/drop-custom-cli
branch
2 times, most recently
from
edd81f1 to
b71912b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package shipped with its own CLI
aiida-s3. The only function was to provide a command that allowed creating new AiiDA profiles using any of the storage backends. As ofaiida-core==2.5, the commandverdi profile setupwas added toverdithat dynamically creates a subcommand for each storage plugin that is registered.The requirement is updated to
aiida-core~=2.5. The custom CLI is removed entirely. The storage plugins remove the_get_cli_optionsmethods and adds the new pydantic model definition that replaces it.