Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devops: Make use of the improved fixtures in aiida-core #31

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

sphuber
Copy link
Owner

@sphuber sphuber commented Apr 7, 2024

The fixtures now provide the config_psql_dos fixture with the
difference that it no longer provides the dictionary of an entire
profile but just the storage configuration. The new tmp_aiida_profile
is used to create a temporary profile with arbitrary storage on the fly.

@sphuber sphuber force-pushed the feature/improved-fixtures branch 5 times, most recently from 581dc8c to c199bcd Compare April 9, 2024 07:53
@sphuber sphuber changed the title WIP Devops: Make use of the improved fixtures in aiida-core Apr 9, 2024
Copy link

@sebaB003 sebaB003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in aiida-core have been merged in the main branch, the upade should proceed with the following pull request.

@sphuber
Copy link
Owner Author

sphuber commented Apr 17, 2024

Thanks @sebaB003 . I just opened the PR to test the new interface. I am holding off with merging this until the new functionality is released with AiiDA v2.6 which is relatively soon. I don't want to build of a branch of aiida-core in this package

The fixtures now provide the `config_psql_dos` fixture with the
difference that it no longer provides the dictionary of an entire
profile but just the storage configuration. The new `aiida_profile_factory`
is used to create a temporary profile with arbitrary storage on the fly.
@sphuber sphuber force-pushed the feature/improved-fixtures branch from c199bcd to 790fb2e Compare July 1, 2024 15:10
@sphuber sphuber merged commit 1f925d7 into master Jul 1, 2024
10 checks passed
@sphuber sphuber deleted the feature/improved-fixtures branch July 1, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants