Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use make update-go-verison to update go version in Dockerfile #3310

Closed
wants to merge 1 commit into from

Conversation

duanmengkk
Copy link

@duanmengkk duanmengkk commented Mar 13, 2024

Thanks for contributing!

What type of PR is this?

release/none

What this PR does / why we need it:
release/none

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@ty-dc
Copy link
Collaborator

ty-dc commented Mar 13, 2024

It seems that there is this tag environment variable, but it got a null value in CI.

echo "tag=$(git ls-tree --full-tree HEAD -- ./images/spiderpool-base | awk '{ print $3 }')" >> $GITHUB_ENV

@duanmengkk
Copy link
Author

It seems that there is this tag environment variable, but it got a null value in CI.

echo "tag=$(git ls-tree --full-tree HEAD -- ./images/spiderpool-base | awk '{ print $3 }')" >> $GITHUB_ENV

yes, I'm not very familiar with this area, could you tell me how to fix the CI errors? @ty-dc

@ty-dc
Copy link
Collaborator

ty-dc commented Mar 13, 2024

It seems that there is this tag environment variable, but it got a null value in CI.

echo "tag=$(git ls-tree --full-tree HEAD -- ./images/spiderpool-base | awk '{ print $3 }')" >> $GITHUB_ENV

yes, I'm not very familiar with this area, could you tell me how to fix the CI errors? @ty-dc

Maybe setting the fetch-depth field to 0 will make CI pass, you can try it.

      - name: Checkout Source Code
        uses: actions/checkout@v4
        with:
          persist-credentials: false
          fetch-depth: 0
          ref: ${{ env.event_ref }}

@duanmengkk
Copy link
Author

duanmengkk commented Mar 15, 2024

My code is
image
and the log in ci is
image

It seems my code is not work,Maybe you can fix it first

@ty-dc
Copy link
Collaborator

ty-dc commented Mar 15, 2024

I tried it and it seems to work.

/usr/bin/docker buildx build --file ./images/spiderpool-base/Dockerfile --iidfile /home/runner/work/_temp/docker-actions-toolkit-jDPRjT/iidfile --platform linux/amd64,linux/arm64 --provenance false --tag ghcr.io/ty-dc/spiderpool/spiderpool-base:44bfacb93132697eacbdd5faddcfc8b38894ead3 --metadata-file /home/runner/work/_temp/docker-actions-toolkit-jDPRjT/metadata-file --push ./images/spiderpool-base

See if it helps you? refer to here

@ty-dc
Copy link
Collaborator

ty-dc commented Mar 18, 2024

In PR #3316 I tested this phenomenon. This is a CI bug, but due to the default nature of the action: "The submitted PR contains workflow changes, but when running CI, the process triggered by the workflow of the main branch is still used."

I submitted a PR to pre-fix this issue, you can rebase the main branch later. thanks .

@ty-dc
Copy link
Collaborator

ty-dc commented Mar 19, 2024

Hi, a friendly push @duanmengkk , the problem is fixed, you can rebase main, thank you.

@duanmengkk duanmengkk closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/none no release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants