Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scanAll typo #4157

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: scanAll typo #4157

merged 1 commit into from
Oct 31, 2024

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Oct 10, 2024

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4203

Special notes for your reviewer:

@ty-dc ty-dc added release/bug cherrypick-release-v0.8 Cherry-pick the PR to branch release-v0.8. cherrypick-release-v0.9 cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. labels Oct 10, 2024
@ty-dc ty-dc requested a review from weizhoublue as a code owner October 10, 2024 10:32
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.18%. Comparing base (ea7f44d) to head (e5bfe08).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ip/cidr.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4157      +/-   ##
==========================================
- Coverage   79.27%   79.18%   -0.10%     
==========================================
  Files          52       52              
  Lines        5901     5903       +2     
==========================================
- Hits         4678     4674       -4     
- Misses       1051     1055       +4     
- Partials      172      174       +2     
Flag Coverage Δ
unittests 79.18% <25.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/ip/cidr.go 95.94% <25.00%> (-4.06%) ⬇️

... and 1 file with indirect coverage changes

@weizhoublue
Copy link
Collaborator

统一 纠正 更多后,再合入

weizhoublue
weizhoublue previously approved these changes Oct 12, 2024
@ty-dc
Copy link
Collaborator Author

ty-dc commented Oct 14, 2024

统一 纠正 更多后,再合入

等待更多类似问题纠正后再合入。

@ty-dc ty-dc requested a review from windsonsea as a code owner October 28, 2024 01:53
@ty-dc ty-dc force-pushed the fix/scall-all branch 3 times, most recently from 99a041d to d842674 Compare October 28, 2024 06:15
@ty-dc ty-dc force-pushed the fix/scall-all branch 3 times, most recently from b4eaa54 to 1f40904 Compare October 30, 2024 12:05
@ty-dc ty-dc force-pushed the fix/scall-all branch 6 times, most recently from 63d3607 to 22b3519 Compare October 31, 2024 06:47
Signed-off-by: tao.yang <[email protected]>
@weizhoublue weizhoublue added release/none no release note and removed release/bug labels Oct 31, 2024
@weizhoublue weizhoublue merged commit 3e1d46b into spidernet-io:main Oct 31, 2024
56 of 58 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
@weizhoublue weizhoublue mentioned this pull request Oct 31, 2024
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
@weizhoublue weizhoublue mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-release-v0.8 Cherry-pick the PR to branch release-v0.8. cherrypick-release-v0.9 cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. release/none no release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some typos in Spiderpool code
3 participants