Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pod mutating webhook to auto inject the pod RDMA resources #4239

Merged

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #

Special notes for your reviewer:

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 54.96183% with 118 lines in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (6c4685f) to head (7ca21a8).
Report is 2 commits behind head on release-v1.0.

Files with missing lines Patch % Lines
pkg/podmanager/utils.go 66.97% 65 Missing and 6 partials ⚠️
pkg/podmanager/pod_webhook.go 0.00% 47 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v1.0    #4239      +/-   ##
================================================
- Coverage         80.76%   79.59%   -1.18%     
================================================
  Files                50       51       +1     
  Lines              5510     5772     +262     
================================================
+ Hits               4450     4594     +144     
- Misses              902     1014     +112     
- Partials            158      164       +6     
Flag Coverage Δ
unittests 79.59% <54.96%> (-1.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/podmanager/pod_manager.go 94.38% <ø> (ø)
pkg/podmanager/pod_webhook.go 0.00% <0.00%> (ø)
pkg/podmanager/utils.go 65.98% <66.97%> (+7.36%) ⬆️

@weizhoublue weizhoublue changed the title Add a pod mutating webhook to auto inject the pod network resources Add a pod mutating webhook to auto inject the pod RDMA resources Oct 30, 2024
@weizhoublue weizhoublue merged commit 2df41f1 into spidernet-io:release-v1.0 Oct 30, 2024
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/feature-new release note for new feature release-v1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants