Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scanAll typo #4253

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Oct 31, 2024

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4247

Special notes for your reviewer:

Signed-off-by: tao.yang <[email protected]>
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (5179a27) to head (dabd8f9).
Report is 4 commits behind head on release-v0.8.

Files with missing lines Patch % Lines
pkg/ip/cidr.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v0.8    #4253      +/-   ##
================================================
- Coverage         81.06%   81.01%   -0.05%     
================================================
  Files                49       49              
  Lines              5418     5420       +2     
================================================
- Hits               4392     4391       -1     
- Misses              864      866       +2     
- Partials            162      163       +1     
Flag Coverage Δ
unittests 81.01% <25.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/ip/cidr.go 95.23% <25.00%> (-4.77%) ⬇️

@weizhoublue weizhoublue merged commit 98393cd into spidernet-io:release-v0.8 Nov 4, 2024
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants