fix: fixed issues with ESM conversion not working #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Difficult problem to solve since both TypeScript and Jest had specific issues that needed to be addressed. Node firstly required that relative files resolve exactly, so now using the "exports" key to achieve this. Then TypeScript was properly reading this key, but wasn't able to figure out where the .d.ts files were, so now using the "typesVersions" key to achieve this. Then Jest didn't know how to read the "exports" key and generally couldn't test the project anymore, so now using the "enhanced-resolve" resolver to try and resolve files with first (has proper support for ESM, it would appear). Lastly, changed coverage to look at .js files instead of .ts files, so the codecov report is going to look strange here. fix #222
spiltcoffee
force-pushed
the
esm-tsconfig
branch
5 times, most recently
from
51c8291 to
20230d9
Compare
|
May need to investigate this: https://github.com/SitePen/remap-istanbul |
spiltcoffee
force-pushed
the
esm-tsconfig
branch
from
20230d9 to
93da8f9
Compare
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
===========================================
- Coverage 100.00% 98.43% -1.57%
===========================================
Files 33 34 +1
Lines 309 446 +137
Branches 56 71 +15
===========================================
+ Hits 309 439 +130
- Misses 0 1 +1
- Partials 0 6 +6
Continue to review full report at Codecov.
|
spiltcoffee
force-pushed
the
esm-tsconfig
branch
6 times, most recently
from
a6fc29d to
686daa5
Compare
spiltcoffee
force-pushed
the
esm-tsconfig
branch
from
686daa5 to
5305b9a
Compare
|
Will reduce code coverage, but only because of more accurate information. |
|
🎉 This PR is included in version 7.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues is this pull request related to?
#222
What changes were made in this pull request?
Difficult problem to solve since both TypeScript and Jest had specific issues that needed to be
addressed.
Node firstly required that relative files resolve exactly, so now using the "exports" key to achieve this.
Then TypeScript was properly reading this key, but wasn't able to figure out where the .d.ts files were, so now using the "typesVersions" key to achieve this.
Then Jest didn't knowhow to read the "exports" key and generally couldn't test the project anymore, so now using the "enhanced-resolve" resolver to try and resolve files with first (has proper support for ESM, it would appear).
Lastly, changed coverage to look at .js files instead of .ts files, so the codecov report is going to look strange here.