This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
Rename seeEmailsSent() to seeEmailCountEquals() #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ssfinney I think that this looks great, but I think that we should consider keeping a seeEmailsSent method that calls the seeEmailCountEquals method? We could mark the seeEmailsSent method deprecated in the docblock. This maybe a waste as there have been so few downloads at this time, but should we consider it? |
|
@ssfinney Also, you need to update the method name in the readme. Thanks. |
|
@jimmypuckett I don't have a preference, so sure. What's the amount of time people typically keep deprecated methods? Maybe we could take this change, and some of the "bigger" issues like #18 and #15, then make a new minor version (0.1.0). Also, do we need a changelog? |
|
@jimmypuckett I've made that change |
jimmypuckett
added a commit
that referenced
this pull request
Feb 27, 2016
Rename seeEmailsSent() to seeEmailCountEquals()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19