Skip to content

Implement SpinApp per-request invocation limits #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kate-goldenring
Copy link
Contributor

@kate-goldenring kate-goldenring commented Jun 17, 2025

Tested with Spintainer executor:

apiVersion: core.spinkube.dev/v1alpha1
kind: SpinAppExecutor
metadata:
  name: spintainer
spec:
  createDeployment: true
  deploymentConfig:
    installDefaultCACerts: true
    spinImage: ghcr.io/spinframework/spin:v3.3.0
---
apiVersion: core.spinkube.dev/v1alpha1
kind: SpinApp
metadata:
  name: cpu-load-gen
spec:
  image: "ghcr.io/spinkube/spin-operator/cpu-load-gen:20240311-163328-g1121986"
  executor: spintainer
  replicas: 1
  invocationLimits:
    # memory: "10Mi" # Will succeed
    memory: "1000" # Will fail. Check Spintainer pod logs to see error: 2025-06-17T23:16:15.009686Z ERROR spin_trigger_http::server: Error processing request: memory minimum size of 2 pages exceeds memory limits 

- Implements SKIP 6: https://github.com/spinframework/skips/tree/main/proposals/006-spinapp-invocation-limits
- Adds validation check for the knownn "memory" limit

Signed-off-by: Kate Goldenring <[email protected]>
@kate-goldenring kate-goldenring force-pushed the spinapp-invocation-limits branch from 0378c9c to 4e18956 Compare June 17, 2025 23:39
@kate-goldenring kate-goldenring requested a review from Mossaka June 18, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant