feat: Add automatic git repository initialization to spin new command
#3155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iamrajiv <[email protected]>
Signed-off-by: iamrajiv <[email protected]>
itowlson
reviewed
Jun 12, 2025
| partial_file.context("Error scanning template partials directory")?; | ||
| if !partial_file.file_type().is_ok_and(|t| t.is_file()) { | ||
| anyhow::bail!("Non-file in partials directory: {partial_file:?}"); | ||
| match self.template.partials_dir() { |
There was a problem hiding this comment.
It's not clear to me why partials support needs to change as part of this. Should this be a separate PR or is it needed here?
| .await | ||
| .understand_git_result() | ||
| .map(|_| ()) | ||
| .map_err(|e| anyhow::anyhow!("{}", e)) |
There was a problem hiding this comment.
This seems like it might be equivalent to git.output().await.understand_git_result()?; - not sure but those maps seem a bit odd.
| } | ||
|
|
||
| if let Err(e) = self.init_git_repo(&target_dir).await { | ||
| eprintln!("Warning: Failed to initialize a git repository for you: {}", e); |
itowlson
requested changes
Jun 12, 2025
| @@ -19,9 +19,6 @@ use crate::{ | |||
| template::Template, | |||
| }; | |||
|
|
|||
| /// A set of partials to be included in a Liquid template. | |||
| type PartialsBuilder = liquid::partials::EagerCompiler<liquid::partials::InMemorySource>; | |||
There was a problem hiding this comment.
Removing this is making the compile fail - I am not sure how you were even able to test it in the current state! Whatever the intent, I suggest we back out the partials changes from this PR - I cannot imagine any reason they'd need to change for git init support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2580
FYI: