Don't mark outbound http spans as errors. #3158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
reviewed
Jun 13, 2025
We log errors in all the cases that are legit (non-user) related errors and so there's no need to also mark the span as errored. This prevents user related issues (e.g., timeouts) from not being bubbled up to telemetry as errors. Additionally, we stop renaming the span after the http method which isn't very helpful. Signed-off-by: Ryan Levick <[email protected]>
lann
reviewed
Jun 13, 2025
lann
reviewed
Jun 13, 2025
|
|
||
| use crate::intercept::InterceptOutcome; | ||
|
|
||
| impl spin_http::Host for crate::InstanceState { | ||
| #[instrument(name = "spin_outbound_http.send_request", skip_all, err(level = Level::INFO), |
There was a problem hiding this comment.
I can never quite remember how all of these things translate into various outputs but I think the name override here helps to distinguish this from the wasi send_request.
...except that the wasi send_request has the same name as this one (oops! 😅)
There was a problem hiding this comment.
The reason I removed this is because it seems to be overwritten completely with the write to otel.name (at least when viewing in HoneyComb - I haven't checked in DataDog).
There was a problem hiding this comment.
Yes, it is likely completely replaced for any otel exporter but would still show up in the tracing_subscriber::fmt output(s) and be used by RUST_LOG filters. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We log errors in all the cases that are legit (non-user) related errors and so there's no need to also mark the span as errored. This prevents user related issues (e.g., timeouts) from not being bubbled up to telemetry as errors.
Additionally, we stop renaming the span after the http method which isn't very helpful.