Update to Wasmtime 34.0.0 #3172
Merged
+484
−579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates to the [34.0.0 release of Wasmtime][rel] where the main impact in terms of API changes is the introduction of the `HasData` trait and refactoring of `add_to_linker*` functions. This now requires type annotations on bindgen-generated `add_to_linker` functions throughout the codebase. Another minor impact is that Wasmtime now requires `'static` to be specified on a few locations `T` shows up for `Store<T>`, but this was just a few small annotations here and there within Spin. [rel]: https://github.com/bytecodealliance/wasmtime/releases/tag/v34.0.0 Signed-off-by: Alex Crichton <[email protected]>
rylev
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates to the 34.0.0 release of Wasmtime where the main impact in terms of API changes is the introduction of the
HasDatatrait and refactoring ofadd_to_linker*functions. This now requires type annotations on bindgen-generatedadd_to_linkerfunctions throughout the codebase. Another minor impact is that Wasmtime now requires'staticto be specified on a few locationsTshows up forStore<T>, but this was just a few small annotations here and there within Spin.