make label name consistently use snake_case

Signed-off-by: Rajat Jindal <[email protected]>
spinkube · Feb 29, 2024 · aa7d4c8 · aa7d4c8
1 parent e2c9f1a
commit aa7d4c8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/internal/controller/metrics.go b/internal/controller/metrics.go
@@ -30,13 +30,13 @@ var (
 	spinOperatorSpinAppExecutorInfo = prometheus.NewGaugeVec(
 		prometheus.GaugeOpts{
 			Name: "spin_operator_spinapp_executor_info",
-			Help: "info about spinapp executor labeled by name, namespace, create_deployment and runtimeclass",
+			Help: "info about spinapp executor labeled by name, namespace, create_deployment and runtime_class_name",
 		},
 		[]string{
 			"name",
 			"namespace",
 			"create_deployment",
-			"runtimeclass",
+			"runtime_class_name",
 		},
 	)
 )
diff --git a/internal/controller/spinappexecutor_controller.go b/internal/controller/spinappexecutor_controller.go
@@ -78,17 +78,17 @@ func (r *SpinAppExecutorReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
 
-	runtimeClass := ""
+	runtimeClassName := ""
 	if executor.Spec.DeploymentConfig != nil {
-		runtimeClass = executor.Spec.DeploymentConfig.RuntimeClassName
+		runtimeClassName = executor.Spec.DeploymentConfig.RuntimeClassName
 	}
 
 	// record spin_operator_spinapp_executor_info metric
 	spinOperatorSpinAppExecutorInfo.With(prometheus.Labels{
-		"name":              executor.Name,
-		"namespace":         executor.Namespace,
-		"create_deployment": fmt.Sprintf("%t", executor.Spec.CreateDeployment),
-		"runtimeclass":      runtimeClass,
+		"name":               executor.Name,
+		"namespace":          executor.Namespace,
+		"create_deployment":  fmt.Sprintf("%t", executor.Spec.CreateDeployment),
+		"runtime_class_name": runtimeClassName,
 	}).Set(1)
 
 	// Make sure the finalizer is present