-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic info metrics to spin-operator #113
Conversation
This PR now has an image available for testing:
|
345edab
to
c042b5a
Compare
8dcaa71
to
ea0e15b
Compare
Signed-off-by: Rajat Jindal <[email protected]>
Signed-off-by: Rajat Jindal <[email protected]>
5346ee1
to
3603ab4
Compare
Signed-off-by: Rajat Jindal <[email protected]>
16dce0a
to
fb91987
Compare
Hi @endocrimes @calebschoepp - I think I have addressed all the feedback and guess this is ready for final set of review. thanks. |
Signed-off-by: Rajat Jindal <[email protected]>
I'm not convinced that this is the right way to do this style of metric (or that "info" metrics in general are something we want) - these will emit any time an app changes or at a full 10h resync, which means folks need to be pretty careful about how they use them, to a degree that I think might make them more confusing than helpful. If all you want is a way to populate dropdowns, most dashboard building software will give you ways to do it based on more active metrics. |
This is a gauge, so my understanding is that it will remain available irrespective of the (re) sync time. If that is indeed the case, do you have any other concerns? |
These metrics are going to be a starting point for setting up dashboards for spin app (as per #16 )