Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cleanup): Removing un-implemented dead code #1681

Merged
merged 1 commit into from
Jul 25, 2023
Merged

chore(cleanup): Removing un-implemented dead code #1681

merged 1 commit into from
Jul 25, 2023

Conversation

jasonmcintosh
Copy link
Member

Just some cleanup

jvz
jvz approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These classes always confused me, especially as I started investigating how to support OIDC providers.

@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for merge label Jul 25, 2023
@mergify mergify bot added the auto merged label Jul 25, 2023
@mergify mergify bot merged commit b3989c3 into spinnaker:master Jul 25, 2023
4 checks passed
@jasonmcintosh jasonmcintosh deleted the cleanupUnusedREsources branch July 25, 2023 19:58
@sudhakaropsmx sudhakaropsmx mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvz jvz jvz approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonmcintosh @jvz @spinnakerbot