refactor(test): add EmbeddedRedis to get connection pool for test execution during upgrade to spring boot 2.7.x #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Jun 3, 2024
gate-web/src/test/java/com/netflix/spinnaker/gate/config/RedisConfigTest.java
Outdated
Show resolved
Hide resolved
…cution during upgrade to spring boot 2.7.x While upgrading spring boot 2.7.18, encounter below error during test compilation of gate-web module: ``` Unexpected exception thrown: java.lang.AssertionError: Expecting: <Unstarted application context org.springframework.boot.test.context.assertj.AssertableApplicationContext[startupFailure=org.springframework.context.ApplicationContextException]> to get beans of type: <org.springframework.session.data.redis.config.ConfigureRedisAction>: but context failed to start: org.springframework.context.ApplicationContextException: Failed to start bean 'springSessionRedisMessageListenerContainer'; nested exception is org.springframework.data.redis.listener.adapter.RedisListenerExecutionFailedException: org.springframework.data.redis.RedisConnectionFailureException: Cannot get Jedis connection; nested exception is redis.clients.jedis.exceptions.JedisConnectionException: Could not get a resource from the pool; nested exception is org.springframework.data.redis.RedisConnectionFailureException: Cannot get Jedis connection; nested exception is redis.clients.jedis.exceptions.JedisConnectionException: Could not get a resource from the pool ``` The `com.netflix.spinnaker.gate.config.RedisConfigTest.testCircularDependenciesException` and `com.netflix.spinnaker.gate.config.RedisConfigTest.testCircularDependenciesExceptionSecure` tests generated the above error. The root cause is unavailability of redis resource pool. So, adding EmbeddedRedis to provide resource pool during test execution.
dbyron-sf
approved these changes
Jun 3, 2024
|
included in #1804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading spring boot 2.7.18, encounter below error during test compilation of gate-web module:
The
com.netflix.spinnaker.gate.config.RedisConfigTest.testCircularDependenciesExceptionandcom.netflix.spinnaker.gate.config.RedisConfigTest.testCircularDependenciesExceptionSecuretests generated the above error. The root cause is unavailability of redis resource pool. So, adding EmbeddedRedis to provide resource pool during test execution.