feat(web): add a config property that allows front50 to be the source of truth for applications #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirangodishala
force-pushed
the
front50-to-be-app-source
branch
2 times, most recently
from
11fdcdb
to
a49e888
Compare
kirangodishala
force-pushed
the
front50-to-be-app-source
branch
from
98a7d13
to
44d1b4c
Compare
… of truth for applications
by using
>> { throw exception }
instead of
>> exception
so spock doesn't try to coerce the exception into the return type of the method, with errors like:
ApplicationServiceSpec > when UseFront50AsSourceOfTruth: #checkFront50 and application exists only in clouddriver, but front50 throws an exception > com.netflix.spinnaker.gate.ApplicationServiceSpec.when UseFront50AsSourceOfTruth: true and application exists only in clouddriver, but front50 throws an exception STANDARD_OUT
--------------- Test when UseFront50AsSourceOfTruth: #checkFront50 and application exists only in clouddriver, but front50 throws an exception
2024-09-10 19:21:01.226 ERROR --- [pool-5-thread-1] c.n.s.gate.services.ApplicationService : [] Falling back to application cache
org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object 'java.lang.Exception: fatal exception' with class 'java.lang.Exception' to class 'java.util.Map'
at org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.continueCastOnSAM(DefaultTypeTransformation.java:404)
at org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.continueCastOnNumber(DefaultTypeTransformation.java:315)
at org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.castToType(DefaultTypeTransformation.java:243)
at org.spockframework.runtime.GroovyRuntimeUtil.coerce(GroovyRuntimeUtil.java:49)
at org.spockframework.mock.response.ConstantResponseGenerator.doRespond(ConstantResponseGenerator.java:35)
at org.spockframework.mock.response.SingleResponseGenerator.respond(SingleResponseGenerator.java:32)
at org.spockframework.mock.response.ResponseGeneratorChain.respond(ResponseGeneratorChain.java:44)
at org.spockframework.mock.runtime.MockInteraction.accept(MockInteraction.java:73)
at org.spockframework.mock.runtime.MockInteractionDecorator.accept(MockInteractionDecorator.java:50)
at org.spockframework.mock.runtime.InteractionScope$1.accept(InteractionScope.java:57)
at org.spockframework.mock.runtime.MockController.handle(MockController.java:40)
at org.spockframework.mock.runtime.JavaMockInterceptor.intercept(JavaMockInterceptor.java:86)
at org.spockframework.mock.runtime.DynamicProxyMockInterceptorAdapter.invoke(DynamicProxyMockInterceptorAdapter.java:34)
at jdk.proxy3/jdk.proxy3.$Proxy96.getApplication(Unknown Source)
at com.netflix.spinnaker.gate.services.ApplicationService$Front50ApplicationRetriever$_callWithMdc_closure1.doCall(ApplicationService.groovy:533)
at com.netflix.spinnaker.gate.services.ApplicationService$Front50ApplicationRetriever$_callWithMdc_closure1.call(ApplicationService.groovy)
at com.netflix.spinnaker.security.AuthenticatedRequest.lambda$wrapCallableForPrincipal$0(AuthenticatedRequest.java:272)
at com.netflix.spinnaker.gate.services.ApplicationService$Front50ApplicationRetriever.callWithMdc(ApplicationService.groovy:531)
at com.netflix.spinnaker.gate.services.ApplicationService$Front50ApplicationRetriever.callWithMdc(ApplicationService.groovy)
at com.netflix.spinnaker.gate.services.MdcWrappedCallable.call(MdcWrappedCallable.java:41)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
dbyron-sf
force-pushed
the
front50-to-be-app-source
branch
from
44d1b4c
to
5992b37
Compare
dbyron-sf
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address the issue of UI showing synthetic applications created by Spinnaker itself which are unknown to Front50.
Clouddriver creates these synthetic applications when it is caching resources in a cluster. If the account doesn’t have
onlySpinnakerManagedset to true, it will create an application using the first part of the manifest name. i.e. a deployment with a name of test-abc will result in an application called test being created.Through spinnaker/clouddriver#5777, Clouddriver is equipped with discarding caching manifests whose application name(derived from moniker) doesn't exist in front50 but in spite of this, synthetic applications can exist in the following scenarios:
kubernetes.checkApplicationInFront50is not enabled in clouddriverkubernetes.checkApplicationInFront50in clouddriver.This PR makes sure that when gate is queried for the applications list, it gets the applications from front50 and clouddriver, and only considers the applications returned from front50 to be the source of truth.
It introduces the following property now in Gate, which when enabled discards all the applications that are obtained from clouddriver which are not known to front50.