feat(gate-web): Add delete session tokens from redis endpoint #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete sessions cache code #publish-snapshot fix api tests #publish-snapshot fix sessino service spec test #publish-snapshot
|
We prefer that non-test backend code be written in Java or Kotlin, rather than Groovy. The following files have been added and written in Groovy:
See our server-side conventions here. |
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
juangod-wise
changed the title
mattgogerly
requested changes
Nov 12, 2024
gate-web/src/main/groovy/com/netflix/spinnaker/gate/services/SessionService.groovy
Outdated
Show resolved
Hide resolved
|
|
||
| @Component | ||
| @CompileStatic | ||
| class SessionService { |
There was a problem hiding this comment.
Are you able to rewrite this in Java please?
There was a problem hiding this comment.
And the tests too if you don't mind. We're really trying to avoid new groovy code wherever possible.
…essionService.groovy Co-authored-by: Matt Gogerly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Spring Boot is upgraded and old tokens no longer work, users get 500's until they delete the cookies from their browser, which causes bad user experience.
A way around this is to delete the
spring:session*keys from Redis, as explained here:https://spinnaker.io/changelogs/1.34.0-changelog/#spring-boot-2615
$ redis-cli keys "spring:session*" | xargs redis-cli delIn our case, we don't have CLI access to our Redis instance in Production. Because of this, we wrote a Gate endpoint that deletes the keys from Redis, so it can be triggered in Production with a curl call:
curl -H "Cookie: SESSION=...." -i -X POST https://spinnaker-host/api/v1/auth/deleteSessionCacheI'm sure many other users of Spinnaker have the same issue and could benefit from this.