Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web/test): remove hard-coded port numbers from EchoServiceTest #1828

Merged
merged 2 commits into from
Sep 11, 2024

Commits on Sep 10, 2024

  1. refactor(web/test): remove hard-coded port numbers from EchoServiceTest

    so the test can pass when these ports are in-use:
    
    EchoServiceTest > initializationError FAILED
        java.net.BindException: Address already in use
            at java.base/sun.nio.ch.Net.bind0(Native Method)
            at java.base/sun.nio.ch.Net.bind(Net.java:555)
            at java.base/sun.nio.ch.Net.bind(Net.java:544)
            at java.base/sun.nio.ch.NioSocketImpl.bind(NioSocketImpl.java:648)
            at java.base/java.net.ServerSocket.bind(ServerSocket.java:393)
            at com.squareup.okhttp.mockwebserver.MockWebServer.start(MockWebServer.java:354)
            at com.squareup.okhttp.mockwebserver.MockWebServer.start(MockWebServer.java:337)
            at com.squareup.okhttp.mockwebserver.MockWebServer.start(MockWebServer.java:324)
            at com.netflix.spinnaker.gate.service.EchoServiceTest.setUp(EchoServiceTest.java:57)
    
    While we're at it, also convert from
    junit4 which com.squareup.okhttp.mockwebserver.MockWebServer uses, to junit5, which
    wiremock uses.
    dbyron-sf committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9efc8d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. chore(build): give tests more memory to execute

    to avoid OutOfMemoryErrors
     Please enter the commit message for your changes. Lines starting
    dbyron-sf committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a7a6490 View commit details
    Browse the repository at this point in the history