Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): invoke pipeline config exception handling #1831

Merged
merged 7 commits into from
Sep 26, 2024
Merged

fix(web): invoke pipeline config exception handling #1831

merged 7 commits into from
Sep 26, 2024

Commits on Sep 26, 2024

  1. feat(web): introduce new configuration property services.front50.appl… 

    …icationRefreshInitialDelayMs

which provides an initial delay in milliseconds for the thread that refreshes the
applications cache in ApplicationService

It's primarily to facilitate testing, but it seems reasonable someone might want use it
production to keep things quiet at startup.
    @dbyron-sf @kirangodishala
    dbyron-sf authored and kirangodishala committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    17adfe5 View commit details
    Browse the repository at this point in the history

  2. test(web): demonstrate current behavior of PipelineController.invokeP… 

    …ipelineConfig

as determined by wiremock responses from front50 and orca (InvokePipelineConfigTest)

and when PipelineService.trigger throws an exception (PipelineControllerTest)
    @dbyron-sf @kirangodishala
    dbyron-sf authored and kirangodishala committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    cee5106 View commit details
    Browse the repository at this point in the history

  3. fix(web): let exceptions during PipelineController.invokePipelineConf… 

    …ig bubble up

so gate's http response code more closely reflects what happened
    @dbyron-sf @kirangodishala
    dbyron-sf authored and kirangodishala committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    57459e6 View commit details
    Browse the repository at this point in the history

  4. refactor(web): change PipelineController to use constructor autowiring 

    to prepare for changes to the constructor logic
    @dbyron-sf @kirangodishala
    dbyron-sf authored and kirangodishala committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2384d72 View commit details
    Browse the repository at this point in the history

  5. fix(web): include information from downstream services in error respo… 

    …nses from PipelineController.invokePipelineConfig

by handling RetrofitErrors with SpinnakerRetrofitErrorHandler

As part of this PipelineController.invokePipelineConfig no longer logs its own message for
RetrofitErrors.  There's some loss of information with this, as the initiator of the
downstream communication is from no longer clear.  A subsequent commit restores this.
    @dbyron-sf @kirangodishala
    dbyron-sf authored and kirangodishala committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bf98028 View commit details
    Browse the repository at this point in the history

  6. fix(web): chain Spinnaker*Exceptions in PipelineController.invokePipe… 

    …lineConfig

so it's clear which operation is failing.  This improves both logging and gate's http response.

As part of this, remove the no-op catch and throw for NotFoundException.  With no other
more general catch block, this code isn't necessary.
    @dbyron-sf @kirangodishala
    dbyron-sf authored and kirangodishala committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2cc5df4 View commit details
    Browse the repository at this point in the history

  7. refactor(web): updating custom exception message creation 

    Uses new kork methods to clean up some error handling and custom exception message creation.
    @kirangodishala
    Richard Timpson authored and kirangodishala committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2d60d0d View commit details
    Browse the repository at this point in the history