Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(retrofit): make changes needed to use SpinnakerRetrofitErrorHandler in kork's RetrofitServiceFactory #1842

Closed
wants to merge 3 commits into from
Closed

feat(retrofit): make changes needed to use SpinnakerRetrofitErrorHandler in kork's RetrofitServiceFactory #1842

wants to merge 3 commits into from

Conversation

kirangodishala
Copy link
Contributor

  • replace RetrofitError references in catch blocks with SpinnakerServerException and its subclasses.
  • Update the tests accordingly.
  • This PR needs kork to use SpinnakerRetrofitErrorHandler first in RetrofitServiceFactory

@kirangodishala kirangodishala marked this pull request as draft October 29, 2024 13:11
@dbyron-sf
Copy link
Contributor

UpstreamBadRequest still uses RetrofitError, but I don't think any of those methods are called anymore.

@dbyron-sf
Copy link
Contributor

There are also uses of RetrofitError in gate-web/src/main that I think can disappear too.

@kirangodishala
Copy link
Contributor Author

There are also uses of RetrofitError in gate-web/src/main that I think can disappear too.

Looks like I missed some occurrences which are not in the pattern of catch blocks. Will address them as well.

@kirangodishala
Copy link
Contributor Author

UpstreamBadRequest still uses RetrofitError, but I don't think any of those methods are called anymore.

Will remove.

@dbyron-sf dbyron-sf mentioned this pull request Nov 4, 2024
Merged
@dbyron-sf
Copy link
Contributor

included in #1843

@dbyron-sf dbyron-sf closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirangodishala @dbyron-sf