chore(queue): add an informative toString() in SqlQueue (#120)

The QueueProcessor will now display something like `Using queue SqlQueue(queueName=default, poolName=default)`, which can be useful when there are multiple SqlQueue beans around connected to different sql pools
spinnaker · May 4, 2020 · 68079a5 · 68079a5
1 parent d523a2f
commit 68079a5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/keiko-core/src/main/kotlin/com/netflix/spinnaker/q/QueueProcessor.kt b/keiko-core/src/main/kotlin/com/netflix/spinnaker/q/QueueProcessor.kt
@@ -137,5 +137,5 @@ class QueueProcessor(
 
   @PostConstruct
   fun confirmQueueType() =
-    log.info("Using ${queue.javaClass.simpleName} queue")
+    log.info("Using queue $queue")
 }
diff --git a/keiko-sql/src/main/kotlin/com/netflix/spinnaker/q/sql/SqlQueue.kt b/keiko-sql/src/main/kotlin/com/netflix/spinnaker/q/sql/SqlQueue.kt
@@ -125,10 +125,12 @@ class SqlQueue(
   private val writeRetryBackoffMax = max(sqlRetryProperties.transactions.backoffMs + 50, 100)
 
   init {
-    log.info("Configured $javaClass queue: $queueName")
+    log.info("Configured queue $this")
     initTables()
   }
 
+  override fun toString(): String = "SqlQueue(queueName=$sanitizedName, poolName=$poolName)"
+
   override fun readState(): QueueState {
     withPool(poolName) {
       return doReadState()