Changing the default for fillExecutorEachCycle to true (#151)

A couple of blogs already propose to have the QueueProcessor behavior to fill up the worker thread pool every poll cycle, rather than processing a single message every interval. Co-authored-by: Rob Zienert <[email protected]>
spinnaker · Aug 25, 2020 · 95aca17 · 95aca17
1 parent d83c170
commit 95aca17
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/keiko-core/src/main/kotlin/com/netflix/spinnaker/q/QueueProcessor.kt b/keiko-core/src/main/kotlin/com/netflix/spinnaker/q/QueueProcessor.kt
@@ -41,7 +41,7 @@ class QueueProcessor(
   private val activators: List<Activator>,
   private val publisher: EventPublisher,
   private val deadMessageHandler: DeadMessageCallback,
-  private val fillExecutorEachCycle: Boolean = false,
+  private val fillExecutorEachCycle: Boolean = true,
   private val requeueDelay: Duration = Duration.ofSeconds(0),
   private val requeueMaxJitter: Duration = Duration.ofSeconds(0)
 ) {

diff --git a/keiko-spring/src/main/kotlin/com/netflix/spinnaker/config/QueueProperties.kt b/keiko-spring/src/main/kotlin/com/netflix/spinnaker/config/QueueProperties.kt
@@ -24,7 +24,7 @@ class QueueProperties {
   var handlerThreadNamePrefix: String = "handlers-"
   var handlerCorePoolSize: Int = 20
   var handlerMaxPoolSize: Int = 20
-  var fillExecutorEachCycle: Boolean = false
+  var fillExecutorEachCycle: Boolean = true
   var requeueDelaySeconds: Long = 0
   var requeueMaxJitterSeconds: Long = 0
 }