refactor(tests): convert groovy based test to java while upgrading spockframework to 2.2-groovy-3.0 #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Jul 31, 2024
| } | ||
|
|
||
| @Test | ||
| void testRetryFailureMoreThanMaxretries() { |
There was a problem hiding this comment.
Can you try combining this with testRetryFailureLessThanMaxretries using e.g. CsvSource? That matches the spock tests and reduces a bunch of duplication.
There was a problem hiding this comment.
I suppose testSleepExponentially could get combined too with another param, but since it's separate in spock, I'm OK with it staying separate here.
dbyron-sf
reviewed
Jul 31, 2024
| subscriber.listenForMessages(); | ||
|
|
||
| // then | ||
| verify(messageAcknowledger, atLeastOnce()).ack(any(), any()); |
There was a problem hiding this comment.
Doesn't the groovy test do
Suggested change
| verify(messageAcknowledger, atLeastOnce()).ack(any(), any()); | |
| verify(messageAcknowledger, once()).ack(any(), any()); |
dbyron-sf
reviewed
Jul 31, 2024
|
|
||
| // then | ||
| verify(messageAcknowledger, never()).ack(any(), any()); | ||
| verify(messageAcknowledger, atLeastOnce()).nack(any(), any()); |
There was a problem hiding this comment.
Suggested change
| verify(messageAcknowledger, atLeastOnce()).nack(any(), any()); | |
| verify(messageAcknowledger, once()).nack(any(), any()); |
…ockframework to 2.2-groovy-3.0
While upgrading spockframework from 2.0-groovy-3.0 to 2.2-groovy-3.0, encountered below errors during test execution of kork-exceptions and kork-pubsub-aws modules:
```
java.lang.ExceptionInInitializerError
at org.spockframework.mock.runtime.CglibMockFactory.createMock(CglibMockFactory.java:24)
at org.spockframework.mock.runtime.ProxyBasedMockFactory.create(ProxyBasedMockFactory.java:45)
at org.spockframework.mock.runtime.JavaMockFactory.createInternal(JavaMockFactory.java:58)
at org.spockframework.mock.runtime.JavaMockFactory.create(JavaMockFactory.java:38)
at org.spockframework.mock.runtime.CompositeMockFactory.create(CompositeMockFactory.java:44)
at org.spockframework.lang.SpecInternals.createMock(SpecInternals.java:50)
at org.spockframework.lang.SpecInternals.createMockImpl(SpecInternals.java:305)
at org.spockframework.lang.SpecInternals.createMockImpl(SpecInternals.java:295)
at org.spockframework.lang.SpecInternals.SpyImpl(SpecInternals.java:172)
at com.netflix.spinnaker.kork.core.RetrySupportSpec.should retry until success or #maxRetries attempts is reached(RetrySupportSpec.groovy:28)
Caused by: net.sf.cglib.core.CodeGenerationException: java.lang.reflect.InaccessibleObjectException-->Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) throws java.lang.ClassFormatError accessible: module java.base does not "opens java.lang" to unnamed module @4afcd809
at app//net.sf.cglib.core.ReflectUtils.defineClass(ReflectUtils.java:464)
at app//net.sf.cglib.core.AbstractClassGenerator.generate(AbstractClassGenerator.java:339)
at app//net.sf.cglib.core.AbstractClassGenerator$ClassLoaderData$3.apply(AbstractClassGenerator.java:96)
at app//net.sf.cglib.core.AbstractClassGenerator$ClassLoaderData$3.apply(AbstractClassGenerator.java:94)
at app//net.sf.cglib.core.internal.LoadingCache$2.call(LoadingCache.java:54)
at [email protected]/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at app//net.sf.cglib.core.internal.LoadingCache.createEntry(LoadingCache.java:61)
at app//net.sf.cglib.core.internal.LoadingCache.get(LoadingCache.java:34)
at app//net.sf.cglib.core.AbstractClassGenerator$ClassLoaderData.get(AbstractClassGenerator.java:119)
at app//net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:294)
at app//net.sf.cglib.core.KeyFactory$Generator.create(KeyFactory.java:221)
at app//net.sf.cglib.core.KeyFactory.create(KeyFactory.java:174)
at app//net.sf.cglib.core.KeyFactory.create(KeyFactory.java:153)
at app//net.sf.cglib.proxy.Enhancer.<clinit>(Enhancer.java:73)
... 10 more
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) throws java.lang.ClassFormatError accessible: module java.base does not "opens java.lang" to unnamed module @4afcd809
at net.sf.cglib.core.ReflectUtils$1.run(ReflectUtils.java:61)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:569)
at net.sf.cglib.core.ReflectUtils.<clinit>(ReflectUtils.java:52)
at net.sf.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:243)
at net.sf.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25)
at net.sf.cglib.core.AbstractClassGenerator.generate(AbstractClassGenerator.java:332)
... 22 more
```
In order to fix this issue, converted the groovy based test classes `RetrySupportSpec.groovy` and `SQSSubscriberSpec.groovy` as java test classes.
dbyron-sf
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading spockframework from 2.0-groovy-3.0 to 2.2-groovy-3.0, encountered below errors during test execution of kork-exceptions and kork-pubsub-aws modules:
In order to fix this issue, converted the groovy based test classes
RetrySupportSpec.groovyandSQSSubscriberSpec.groovyas java test classes.