Skip to content

Commit

Permalink
chore(dependency): add explicit assertj-core dependency while spockfr…
Browse files Browse the repository at this point in the history
…amework upgrade to 2.2-groovy-3.0 (#4770)

While upgrading spockframework from 2.0-groovy-3.0 to 2.2-groovy-3.0, encountered below errors during test execution of orca-mine module:
```
/orca/orca-mine/src/test/java/com/netflix/spinnaker/orca/mine/tasks/RegisterCanaryTaskTest.java:22: error: package org.assertj.core.api does not exist
import static org.assertj.core.api.Assertions.assertThatThrownBy;
                                  ^

/orca/orca-mine/src/test/java/com/netflix/spinnaker/orca/mine/tasks/RegisterCanaryTaskTest.java:150: error: cannot find symbol
    assertThatThrownBy(() -> registerCanaryTask.execute(deployCanaryStage))
    ^
  symbol:   method assertThatThrownBy(()->regist[...]tage))
  location: class RegisterCanaryTaskTest
```
To fix this issue added assertj-core dependency explicitly.
  • Loading branch information
j-sandy committed Aug 2, 2024
1 parent 6cc873f commit 3db7078
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions orca-mine/orca-mine.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ dependencies {
implementation("io.spinnaker.kork:kork-retrofit")

testImplementation("org.junit.jupiter:junit-jupiter-params")
testImplementation("org.assertj:assertj-core")
testImplementation("com.github.tomakehurst:wiremock-jre8-standalone")
}

Expand Down

0 comments on commit 3db7078

Please sign in to comment.