feat(child pipeline executions): Add support for omit other stages fr… #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We face some issues about huge contexts in our pipeline executions and this would be a BIG step forward to address it. Is there any ETA planned to merge this into the code base? 🙏🏻 |
|
Maybe ask in spinnaker slack channel, there shouldnt be any problem merging this as it can be tuner on and off with the flag |
|
Really needed some tests for this ;) I like the idea, and it's similar to the skip downstream flag, though operates differently from what I can see. |
Avi1235
force-pushed
the
isolated-pipeline-stageExecutions
branch
2 times, most recently
from
5b1a31f
to
c3de354
Compare
Avi1235
force-pushed
the
isolated-pipeline-stageExecutions
branch
from
7aec873
to
7902999
Compare
|
Ran the workflows please 🙏 , i added a test which proves the child pipeline is isolated only having record of one stage from his parentExecution |
|
Closing since #4620 i believe addresses huge pipelines bodies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a feature flag isolatedStreamExecution that can be defined in Run Pipeline stage. You can enable it via stage or in orca config
stages.pipeline.defaultIsolatedStreamExecutionby enabling it, clears all the info that other stages ran on the parent pipeline in the child - trigger.parentExecution values.PR's related: 3989 4080
issue related 6159
For testing i ran the next pipeline: pipeline stage(trigger son-1) -> manual judgment -> pipeline stage(trigger son-2) -> manual judgment -> pipeline stage(trigger son-3)
The childs(son 1/2/3): only had a wait stage
the body of the last pipeline stage increments due to keeping track of the stages that ran before and created outputs, task etc.
tests after enabling
isolatedStreamExecution: true