refactor(retrofit): use SpinnakerRetrofitErrorHandler as a step towards simplifying exception handling #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kirangodishala
commented
Sep 19, 2023
kirangodishala
commented
- add SpinnakerRetrofitErrorHandler while creating BakeryService
- add retry support to createBake() method in CreateBakeTask
- add retry support to bakeManifest() method in CreateBakeManifestTask
…ds simplifying exception handling - add retry support to createBake() method in CreateBakeTask - add retry support to bakeManifest() method in CreateBakeManifestTask
dbyron-sf
approved these changes
Sep 19, 2023
Pranav-b-7
added a commit
to Pranav-b-7/orca
that referenced
this pull request
Oct 27, 2023
…naker*Exception instead of RetrofitError now that spinnaker#4529 has added SpinnakerRetrofitErrorHandler to BakerySelector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.