-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(queue): Fix SqlQueue#doContainsMessage
to handle queues with more than 100 items
#4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more than 100 items `SqlQueue#doContainsMessage` doesn't process more than 1 batch because of an incorrect loop inside. When the last element in the batch is processed (`ResultSet#next` returns `false`), the following invocation of `ResultSet#getRow` will return 0. No matter how many rows were processed before. Basically, this PR is just a copy of #4184 with addressed comments. But #4184 is abandoned so opened this one. Kudos to Ivor for the original PR
kbatalin
changed the title
fix(queue): Fix
fix(queue): Fix Mar 3, 2024
ZombieExecutionCheckingAgent
to handle queues with more than 100 itemsZombieExecutionCheckingAgent
for SqlQueue
to handle queues with more than 100 items
kbatalin
changed the title
fix(queue): Fix
fix(queue): Fix Mar 10, 2024
ZombieExecutionCheckingAgent
for SqlQueue
to handle queues with more than 100 itemsSqlQueue#doContainsMessage
to handle queues with more than 100 items
jasonmcintosh
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE. And thanks for the tests!!
@Mergifyio backport release-1.33.x release-1.32.x release-1.31.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
…more than 100 items (#4648) `SqlQueue#doContainsMessage` doesn't process more than 1 batch because of an incorrect loop inside. When the last element in the batch is processed (`ResultSet#next` returns `false`), the following invocation of `ResultSet#getRow` will return 0. No matter how many rows were processed before. Basically, this PR is just a copy of #4184 with addressed comments. But #4184 is abandoned so opened this one. Kudos to Ivor for the original PR Co-authored-by: Jason <[email protected]> (cherry picked from commit 0a52909)
mergify bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
…more than 100 items (#4648) `SqlQueue#doContainsMessage` doesn't process more than 1 batch because of an incorrect loop inside. When the last element in the batch is processed (`ResultSet#next` returns `false`), the following invocation of `ResultSet#getRow` will return 0. No matter how many rows were processed before. Basically, this PR is just a copy of #4184 with addressed comments. But #4184 is abandoned so opened this one. Kudos to Ivor for the original PR Co-authored-by: Jason <[email protected]> (cherry picked from commit 0a52909)
mergify bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
…more than 100 items (#4648) `SqlQueue#doContainsMessage` doesn't process more than 1 batch because of an incorrect loop inside. When the last element in the batch is processed (`ResultSet#next` returns `false`), the following invocation of `ResultSet#getRow` will return 0. No matter how many rows were processed before. Basically, this PR is just a copy of #4184 with addressed comments. But #4184 is abandoned so opened this one. Kudos to Ivor for the original PR Co-authored-by: Jason <[email protected]> (cherry picked from commit 0a52909)
This was referenced Mar 23, 2024
mergify bot
added a commit
that referenced
this pull request
Mar 26, 2024
…more than 100 items (#4648) (#4683) `SqlQueue#doContainsMessage` doesn't process more than 1 batch because of an incorrect loop inside. When the last element in the batch is processed (`ResultSet#next` returns `false`), the following invocation of `ResultSet#getRow` will return 0. No matter how many rows were processed before. Basically, this PR is just a copy of #4184 with addressed comments. But #4184 is abandoned so opened this one. Kudos to Ivor for the original PR Co-authored-by: Jason <[email protected]> (cherry picked from commit 0a52909) Co-authored-by: Kirill Batalin <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Mar 26, 2024
…more than 100 items (#4648) (#4685) `SqlQueue#doContainsMessage` doesn't process more than 1 batch because of an incorrect loop inside. When the last element in the batch is processed (`ResultSet#next` returns `false`), the following invocation of `ResultSet#getRow` will return 0. No matter how many rows were processed before. Basically, this PR is just a copy of #4184 with addressed comments. But #4184 is abandoned so opened this one. Kudos to Ivor for the original PR Co-authored-by: Jason <[email protected]> (cherry picked from commit 0a52909) Co-authored-by: Kirill Batalin <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Mar 26, 2024
…more than 100 items (#4648) (#4684) `SqlQueue#doContainsMessage` doesn't process more than 1 batch because of an incorrect loop inside. When the last element in the batch is processed (`ResultSet#next` returns `false`), the following invocation of `ResultSet#getRow` will return 0. No matter how many rows were processed before. Basically, this PR is just a copy of #4184 with addressed comments. But #4184 is abandoned so opened this one. Kudos to Ivor for the original PR Co-authored-by: Jason <[email protected]> (cherry picked from commit 0a52909) Co-authored-by: Kirill Batalin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto merged
Merged automatically by a bot
ready to merge
Approved and ready for merge
target-release/1.34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlQueue#doContainsMessage
doesn't process more than 1 batch because of an incorrect loop inside. When the last element in the batch is processed (ResultSet#next
returnsfalse
), the following invocation ofResultSet#getRow
will return 0. No matter how many rows were processed before.Basically, this PR is just a copy of #4184 with addressed comments. But #4184 is abandoned so opened this one. Kudos to Ivor for the original PR