fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack from Clouddriver API
christosarvanitis
changed the title
...com/netflix/spinnaker/orca/clouddriver/pipeline/servergroup/rollback/ExplicitRollback.groovy
Outdated
Show resolved
Hide resolved
| .get() // not sure what would cause the Optional to not be present but we would catch and log it | ||
| } catch(Exception e) { | ||
| log.error('Could not generate resize stage because there was an error looking up {}', serverGroupName, e) | ||
| throw new SpinnakerException("failed to look up ${serverGroupName}", e) | ||
| throw new SpinnakerException("Failed Clouddriver look up for ${serverGroupName} in ${rollbackTimeout} sec. Consider increasing rollback.explicitRollback.timeout in orca profile.", e) |
…p from Clouddriver API
…p from Clouddriver API
ovidiupopa07
requested changes
Apr 1, 2024
...com/netflix/spinnaker/orca/clouddriver/pipeline/servergroup/rollback/ExplicitRollback.groovy
Show resolved
Hide resolved
…p from Clouddriver API
jasonmcintosh
approved these changes
Apr 2, 2024
|
@Mergifyio backport release-1.32.x release-1.33.x release 1-3.1.x |
❌ No backport have been created
GitHub error:
GitHub error: |
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
…p from Clouddriver API (#4686) * fix(explicitRollback): Add configurable timeout for serverGroup rollback from Clouddriver API * fix(explicitRollback): Fix tests * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API --------- Co-authored-by: Jason <[email protected]> (cherry picked from commit 2b8af02)
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
…p from Clouddriver API (#4686) * fix(explicitRollback): Add configurable timeout for serverGroup rollback from Clouddriver API * fix(explicitRollback): Fix tests * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API --------- Co-authored-by: Jason <[email protected]> (cherry picked from commit 2b8af02)
|
@Mergifyio backport release-1-31.x |
❌ No backport have been created
GitHub error:
GitHub error: |
❌ No backport have been created
GitHub error: |
|
https://github.com/Mergifyio backport release-1.31.x |
❌ No backport have been created
GitHub error: |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
…p from Clouddriver API (#4686) * fix(explicitRollback): Add configurable timeout for serverGroup rollback from Clouddriver API * fix(explicitRollback): Fix tests * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API --------- Co-authored-by: Jason <[email protected]> (cherry picked from commit 2b8af02)
❌ No backport have been created
GitHub error: |
mergify bot
added a commit
that referenced
this pull request
Apr 2, 2024
…p from Clouddriver API (#4686) (#4690) * fix(explicitRollback): Add configurable timeout for serverGroup rollback from Clouddriver API * fix(explicitRollback): Fix tests * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API --------- Co-authored-by: Jason <[email protected]> (cherry picked from commit 2b8af02) Co-authored-by: Christos Arvanitis <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Apr 2, 2024
…p from Clouddriver API (#4686) (#4692) * fix(explicitRollback): Add configurable timeout for serverGroup rollback from Clouddriver API * fix(explicitRollback): Fix tests * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API --------- Co-authored-by: Jason <[email protected]> (cherry picked from commit 2b8af02) Co-authored-by: Christos Arvanitis <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Apr 2, 2024
…p from Clouddriver API (#4686) (#4691) * fix(explicitRollback): Add configurable timeout for serverGroup rollback from Clouddriver API * fix(explicitRollback): Fix tests * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API * fix(explicitRollback): Add configurable timeout for serverGroup lookup from Clouddriver API --------- Co-authored-by: Jason <[email protected]> (cherry picked from commit 2b8af02) Co-authored-by: Christos Arvanitis <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user performs an Ad-Hoc Rollback through Deck, Orca is expecting to receive a response from Clouddriver about the serverGroup details in a hardcoded 5 seconds timeout.
Although in most cases this is enough, in higher scale environments with thousands of AWS/ECS accounts and especially in applications that have a large amount of serverGroups the 5 sec timeout is too strict resulting in error during the serverGroup lookup.
With this change we can configure the timeout (in seconds) through Orca config - while defaulting to the previous timeout of 5secs.