Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(check-pre-condition): CheckPrecondition doesn't evaluate expressi… (backport #4682) #4720

Merged
merged 1 commit into from
May 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 30, 2024

This PR includes the changes to fix the spinnaker/spinnaker#6933

Root cause:
If pipeline created from template, CheckPrecondition doesn't evaluate expression correctly after upstream stages get restarted
Fix:
Replace precondition List with precondition Map containing stage refId and preconditions. Modify the replace condition to replace pre-condition context with corresponding preCondition stage context.


This is an automatic backport of pull request #4682 done by Mergify.

…on correctly after upstream stages get restarted (#4682)

Co-authored-by: ysaxena <[email protected]>
(cherry picked from commit 613427f)
@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for merge label May 7, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label May 7, 2024
@mergify mergify bot merged commit da0d5ca into release-1.31.x May 7, 2024
4 checks passed
@mergify mergify bot deleted the mergify/bp/release-1.31.x/pr-4682 branch May 7, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.31
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants