Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): enable cross compilation plugin for Java 17 #4738

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

mattgogerly
Copy link
Member

Compile to Java 11 bytecode using JDK 17.

Reference: spinnaker/igor#1198

@mattgogerly
Copy link
Member Author

@Mergifyio update

Copy link
Contributor

mergify bot commented Jun 11, 2024

update

✅ Branch has been successfully updated

@mattgogerly mattgogerly added the ready to merge Approved and ready for merge label Jun 11, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Jun 11, 2024
@mergify mergify bot merged commit f936de5 into spinnaker:master Jun 11, 2024
5 checks passed
@mattgogerly mattgogerly deleted the feat/java17 branch June 11, 2024 21:16
dbyron-sf added a commit to dbyron-sf/orca that referenced this pull request Jun 13, 2024
…innaker#4738)"

This reverts commit f936de5.

since $ ./gradlew -PenableCrossCompilerPlugin=true clean orca-api:dokkaJavadoc fails
mergify bot pushed a commit that referenced this pull request Jun 13, 2024
* Revert "fix(dokka): use version 1.9.20 of org.jetbrains.dokka (#4747)"

This reverts commit af347bb.

since https://github.com/spinnaker/orca/actions/runs/9490289564/job/26153470376 failed with:

Caused by: java.lang.NoSuchMethodError: 'org.jetbrains.dokka.model.DInterface org.jetbrains.dokka.model.DInterface.copy$default(org.jetbrains.dokka.model.DInterface, org.jetbrains.dokka.links.DRI, java.lang.String, java.util.Map, org.jetbrains.dokka.DokkaConfiguration$DokkaSourceSet, java.util.Map, java.util.List, java.util.List, java.util.List, java.util.Map, org.jetbrains.dokka.model.DObject, java.util.List, java.util.Map, java.util.Set, boolean, org.jetbrains.dokka.model.properties.PropertyContainer, int, java.lang.Object)'

Kotlin/dokka#2452 has some info, but I haven’t been able to make it work.

* Revert "chore(build): enable cross compilation plugin for Java 17 (#4738)"

This reverts commit f936de5.

since $ ./gradlew -PenableCrossCompilerPlugin=true clean orca-api:dokkaJavadoc fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants