Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): revert java17 changes #4750

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix(build): revert java17 changes #4750

merged 2 commits into from
Jun 13, 2024

Commits on Jun 13, 2024

  1. Revert "fix(dokka): use version 1.9.20 of org.jetbrains.dokka (spinna… 

    …ker#4747)"

This reverts commit af347bb.

since https://github.com/spinnaker/orca/actions/runs/9490289564/job/26153470376 failed with:

Caused by: java.lang.NoSuchMethodError: 'org.jetbrains.dokka.model.DInterface org.jetbrains.dokka.model.DInterface.copy$default(org.jetbrains.dokka.model.DInterface, org.jetbrains.dokka.links.DRI, java.lang.String, java.util.Map, org.jetbrains.dokka.DokkaConfiguration$DokkaSourceSet, java.util.Map, java.util.List, java.util.List, java.util.List, java.util.Map, org.jetbrains.dokka.model.DObject, java.util.List, java.util.Map, java.util.Set, boolean, org.jetbrains.dokka.model.properties.PropertyContainer, int, java.lang.Object)'

Kotlin/dokka#2452 has some info, but I haven’t been able to make it work.
    @dbyron-sf
    dbyron-sf committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    eb4f6e8 View commit details
    Browse the repository at this point in the history

  2. Revert "chore(build): enable cross compilation plugin for Java 17 (sp… 

    …innaker#4738)"

This reverts commit f936de5.

since $ ./gradlew -PenableCrossCompilerPlugin=true clean orca-api:dokkaJavadoc fails
    @dbyron-sf
    dbyron-sf committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    5ee3c70 View commit details
    Browse the repository at this point in the history