-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(batchUpdate): Pipeline config batch update #4773
Merged
mergify
merged 6 commits into
spinnaker:master
from
richard-timpson:pipeline-config-batch-update
Aug 21, 2024
Merged
feat(batchUpdate): Pipeline config batch update #4773
mergify
merged 6 commits into
spinnaker:master
from
richard-timpson:pipeline-config-batch-update
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
richard-timpson
force-pushed
the
pipeline-config-batch-update
branch
from
August 13, 2024 17:27
cfdb31d
to
1a9743f
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
…s at once to sql database. This is part of: spinnaker/spinnaker#6147. Enhanced SavePipelineTask.java to Added code to ensure that the SavePipelineTask.java also accepts list of pipelines json. This method will validate all the pipelines. This method will call the front50 service to save the pipelines list. Enhanced Front50Service.groovy to Added new rest api which accepts list of pipelines json.
Adds configuration properties for readTimeout, writeTimeout, and connectTimeout on the Front50 OkHttp service.
richard-timpson
force-pushed
the
pipeline-config-batch-update
branch
from
August 20, 2024 22:12
55f650d
to
14d6c5f
Compare
dbyron-sf
reviewed
Aug 21, 2024
dbyron-sf
reviewed
Aug 21, 2024
orca-front50/src/main/java/com/netflix/spinnaker/orca/front50/tasks/SavePipelineTask.java
Outdated
Show resolved
Hide resolved
Test was failing without it. The test code that uses it was added back when we were in Groovy 2, after the upgrade to Groovy 3 I believe it's required as an explicit dependency.
richard-timpson
force-pushed
the
pipeline-config-batch-update
branch
from
August 21, 2024 22:21
993001b
to
bbf9916
Compare
dbyron-sf
approved these changes
Aug 21, 2024
richard-timpson
pushed a commit
to richard-timpson/spinnaker.io
that referenced
this pull request
Aug 23, 2024
…e functionality The documentation for front50 already existed. Adds some sections for the gate and orca changes which make the functionality feature complete. See relevant PRs spinnaker/front50#1483, spinnaker/orca#4773, and spinnaker/gate#1823
dbyron-sf
pushed a commit
to spinnaker/spinnaker.io
that referenced
this pull request
Aug 23, 2024
…e functionality (#458) The documentation for front50 already existed. Adds some sections for the gate and orca changes which make the functionality feature complete. See relevant PRs spinnaker/front50#1483, spinnaker/orca#4773, and spinnaker/gate#1823 Co-authored-by: Richard Timpson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change is dependent on spinnaker/front50#1483
Added code to save multiple pipelines at once to sql database.
This is part of: spinnaker/spinnaker#6147.
Enhanced SavePipelineTask.java to
Added code to ensure that the SavePipelineTask.java also accepts list of pipelines json.
This method will validate all the pipelines.
This method will call the front50 service to save the pipelines list.
Enhanced Front50Service.groovy to
Added new rest api which accepts list of pipelines json.
Also contains some changes to make the timeout values in the front50 client configurable. They all default to 10000: