Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batchUpdate): Pipeline config batch update #4773

Merged

Conversation

richard-timpson
Copy link
Contributor

@richard-timpson richard-timpson commented Aug 12, 2024

Change is dependent on spinnaker/front50#1483

Added code to save multiple pipelines at once to sql database.

This is part of: spinnaker/spinnaker#6147.

Enhanced SavePipelineTask.java to

Added code to ensure that the SavePipelineTask.java also accepts list of pipelines json.
This method will validate all the pipelines.
This method will call the front50 service to save the pipelines list.

Enhanced Front50Service.groovy to

Added new rest api which accepts list of pipelines json.

Also contains some changes to make the timeout values in the front50 client configurable. They all default to 10000:

  • front50.okhttp.readTimeoutMs
  • front50.okhttp.writeTimeoutMs
  • front50.okhttp.connectTimeoutMs

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • cfdb31d: Support for bulk saving pipelines (#33)

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@dbyron-sf
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Aug 19, 2024

update

✅ Branch has been successfully updated

sanopsmx and others added 3 commits August 20, 2024 16:12
…s at once to sql database.

This is part of: spinnaker/spinnaker#6147.

Enhanced SavePipelineTask.java to

Added code to ensure that the SavePipelineTask.java also accepts list of pipelines json.
This method will validate all the pipelines.
This method will call the front50 service to save the pipelines list.

Enhanced Front50Service.groovy to

Added new rest api which accepts list of pipelines json.
Adds configuration properties for readTimeout, writeTimeout, and connectTimeout on the Front50 OkHttp service.
@richard-timpson richard-timpson marked this pull request as ready for review August 20, 2024 22:15
Richard Timpson added 3 commits August 21, 2024 16:16
Test was failing without it. The test code that uses it was added back when we were in Groovy 2, after the upgrade to Groovy 3 I believe it's required as an explicit dependency.
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Aug 21, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Aug 21, 2024
@mergify mergify bot merged commit 1d85e7c into spinnaker:master Aug 21, 2024
4 checks passed
richard-timpson pushed a commit to richard-timpson/spinnaker.io that referenced this pull request Aug 23, 2024
…e functionality

The documentation for front50 already existed. Adds some sections for the gate and orca changes which make the functionality feature complete.

See relevant PRs
spinnaker/front50#1483, spinnaker/orca#4773, and spinnaker/gate#1823
dbyron-sf pushed a commit to spinnaker/spinnaker.io that referenced this pull request Aug 23, 2024
…e functionality (#458)

The documentation for front50 already existed. Adds some sections for the gate and orca changes which make the functionality feature complete.

See relevant PRs
spinnaker/front50#1483, spinnaker/orca#4773, and spinnaker/gate#1823

Co-authored-by: Richard Timpson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants