Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(keiko-redis): test logging cleanups #4775

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

dbyron-sf
Copy link
Contributor

No description provided.

@dbyron-sf dbyron-sf marked this pull request as ready for review August 16, 2024 20:39
Copy link
Member

@christosarvanitis christosarvanitis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

so test output contains log messages and to avoid these error messages:

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
SLF4J: Failed to load class "org.slf4j.impl.StaticMDCBinder".
SLF4J: Defaulting to no-operation MDCAdapter implementation.
SLF4J: See http://www.slf4j.org/codes.html#no_static_mdc_binder for further details.
…ng tests

so test output contains log messages and to avoid these error messages:

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Aug 28, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Aug 28, 2024
@mergify mergify bot merged commit eb61f0e into spinnaker:master Aug 28, 2024
4 checks passed
@dbyron-sf dbyron-sf deleted the keiko-redis-cleanups branch August 28, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.36
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants