chore(runJobStage): Fix logs annotation processing on manifest artifact #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's involved in adding a test for this? |
christosarvanitis
force-pushed
the
fixRunJobLogsFromManifestArtifact
branch
from
5f2f77e
to
8c87776
Compare
christosarvanitis
force-pushed
the
fixRunJobLogsFromManifestArtifact
branch
from
3aa53ad
to
a7dde0b
Compare
|
@dbyron-sf pushed some tests for the stage |
jasonmcintosh
approved these changes
Sep 10, 2024
christosarvanitis
added a commit
to armory-io/orca
that referenced
this pull request
Sep 19, 2024
christosarvanitis
added a commit
to armory-io/orca
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the RunJob Stage when the annotation:
is present the expectation is that the context will be amended with:
which is rendered by Deck to an external URL for the console logs.
This is working as expected when the source is text (inline manifest) but when the manifest is coming from an artifact store the process needs to happen afterStages because only then the manifest content is present in the context
This PR addresses this missing use case.