Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stageExecution): reduce execution context size #4781

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kirangodishala
Copy link
Contributor

@kirangodishala kirangodishala commented Sep 17, 2024

Introduced new config classes for the following Tasks:

  • WaitOnJobCompletionTask
  • BindProducedArtifactsTask
  • PromoteManifestKatoOutputsTask
  • ResolveDeploySourceManifestTask

Through these config classes, certain keys from the outputs in the stage context can be removed.

Added unit tests for these tasks.

Here are the configuration properties to exclude the keys:

tasks:
  clouddriver:
    promoteManifestKatoOutputsTask:
      excludeKeysFromOutputs:
      - outputs.createdArtifacts
      - outputs.manifests
      - outputs.boundArtifacts
    waitOnJobCompletionTask:
      excludeKeysFromOutputs:
      - jobStatus
      - completionDetails
    resolveDeploySourceManifestTask:
      excludeKeysFromOutputs:
      - manifests
      - requiredArtifacts
      - optionalArtifacts
  core:
    bindProducedArtifactsTask:
      excludeKeysFromOutputs:
      - artifacts

- there are a lot of fields that are duplicated in the stage context and stage outputs. This commit removes some of the duplication.

- use a config class(TaskConfigurationProperties) instead of dynamic config service.This helps in loading configs of type list more easily, without having to resort to reading them as strings and then splitting them on a delimiter
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Sep 19, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Sep 19, 2024
@mergify mergify bot merged commit b06b8c8 into spinnaker:master Sep 19, 2024
5 checks passed
kirangodishala added a commit to kirangodishala/spinnaker.io that referenced this pull request Sep 19, 2024
kirangodishala added a commit to kirangodishala/spinnaker.io that referenced this pull request Sep 19, 2024
kirangodishala added a commit to kirangodishala/spinnaker.io that referenced this pull request Sep 20, 2024
kirangodishala added a commit to kirangodishala/spinnaker.io that referenced this pull request Sep 20, 2024
kirangodishala added a commit to kirangodishala/spinnaker.io that referenced this pull request Sep 20, 2024
dbyron-sf pushed a commit to spinnaker/spinnaker.io that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants